-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44315/39335
|
A new Pull Request was created by @BenjaminRS for master. It involves the following packages:
@srimanob, @aloeliger, @subirsarkar, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37905/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Please squash the commits, so that files are not added and removed. |
E2E NNVtx code for P2 L1T Primary Vertex Reconstruction Adding the network graphs Updating based on L1T OffSW review in PR#1191 Updating for the FileInPath
7223df4
to
5c0d13a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44315/39360
|
Pull request #44315 was updated. @aloeliger, @epalencia, @cmsbuild, @subirsarkar, @srimanob can you please check and sign again. |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37941/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR holds the E2E NNVtx code for P2 L1T Primary Vertex Reconstruction. The work has been presented many times over the years including in:
https://cds.cern.ch/record/2792619?ln=en
https://cds.cern.ch/record/2814727?ln=en
And most recently: https://indico.cern.ch/event/1356822/#58-update-on-e2e-nnvtx
The L1T Integration branch version is here: cms-l1t-offline#1216
The model files needed by this NN are in the following PRs: cms-data/L1Trigger-VertexFinder#1 and cms-data/L1Trigger-L1TTrackMatch#1
PR validation:
Previously under cms-l1t-offline#1191 the following validations were performed:
This PR passes the following checks:
scram b
scram b code-format
scram b code-checks
scram b runtests
runTheMatrix.py -l limited -i all --ibeos
time cmsRun L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py