E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315

BenjaminRS · 2024-03-05T14:04:54Z

PR description:

This PR holds the E2E NNVtx code for P2 L1T Primary Vertex Reconstruction. The work has been presented many times over the years including in:
https://cds.cern.ch/record/2792619?ln=en
https://cds.cern.ch/record/2814727?ln=en
And most recently: https://indico.cern.ch/event/1356822/#58-update-on-e2e-nnvtx

The L1T Integration branch version is here: cms-l1t-offline#1216
The model files needed by this NN are in the following PRs: cms-data/L1Trigger-VertexFinder#1 and cms-data/L1Trigger-L1TTrackMatch#1

PR validation:

Previously under cms-l1t-offline#1191 the following validations were performed:
This PR passes the following checks: 
 scram b
scram b code-format 
scram b code-checks
scram b runtests
runTheMatrix.py -l limited -i all --ibeos
time cmsRun L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py

cmsbuild · 2024-03-05T14:05:18Z

cms-bot internal usage

cmsbuild · 2024-03-05T14:11:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44315/39335

This PR adds an extra 88KB to repository
Found files with invalid states:
- L1Trigger/VertexFinder/data/Quantised_model_prune_iteration_9_weightModelgraph.pb:
  - Added: d6364e8
  - Deleted: 4231a75
- L1Trigger/L1TTrackMatch/data/Quantised_model_prune_iteration_9_associationModelgraph.pb:
  - Added: d6364e8
  - Deleted: 4231a75
- L1Trigger/VertexFinder/data/Quantised_model_prune_iteration_9_patternModelgraph.pb:
  - Added: d6364e8
  - Deleted: 4231a75
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py modified in PR(s): Triplet emulator 14 0 0 pre3 #43998

cmsbuild · 2024-03-05T14:11:59Z

A new Pull Request was created by @BenjaminRS for master.

It involves the following packages:

DataFormats/L1TrackTrigger (l1, upgrade)
L1Trigger/L1TTrackMatch (l1, upgrade)
L1Trigger/TrackFindingTracklet (l1)
L1Trigger/VertexFinder (l1)

@srimanob, @aloeliger, @subirsarkar, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @sviret, @rovere, @missirol, @skinnari, @erikbutz this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

epalencia · 2024-03-05T15:30:36Z

test parameters:

pull_request = Adding the association network E2E NNVtx cms-data/L1Trigger-L1TTrackMatch#1
pull_request = Adding the pattern and weight networks for E2E NNVtx cms-data/L1Trigger-VertexFinder#1

epalencia · 2024-03-05T15:31:18Z

please test

cmsbuild · 2024-03-05T23:11:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37905/summary.html
COMMIT: 7223df4
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44315/37905/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37905/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37905/git-merge-result

Comparison Summary

Summary:

You potentially removed 50 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 92 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3338730
DQMHistoTests: Total failures: 857
DQMHistoTests: Total nulls: 278
DQMHistoTests: Total successes: 3337573
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3127.2979999999993 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.225 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 12834.0,... ): 290.639 KiB HLT/JME
DQMHistoSizes: changed ( 12834.0,... ): 201.957 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 12834.0,... ): 24.847 KiB HLT/EGM
DQMHistoSizes: changed ( 12834.0,... ): 15.354 KiB HLT/Filters
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: found differences in 7 / 47 workflows

fwyzard · 2024-03-06T05:32:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44315/39335

* This PR adds an extra 88KB to repository

* Found files with invalid states:
  
  * L1Trigger/VertexFinder/data/Quantised_model_prune_iteration_9_weightModelgraph.pb:
    
    * Added: [d6364e8](https://github.com/cms-sw/cmssw/commit/d6364e86d7e655457796816c1259fa465d17b533)
    * Deleted: [4231a75](https://github.com/cms-sw/cmssw/commit/4231a7504ef68b12536ef6245f83c3602d0b8b82)
  * L1Trigger/L1TTrackMatch/data/Quantised_model_prune_iteration_9_associationModelgraph.pb:
    
    * Added: [d6364e8](https://github.com/cms-sw/cmssw/commit/d6364e86d7e655457796816c1259fa465d17b533)
    * Deleted: [4231a75](https://github.com/cms-sw/cmssw/commit/4231a7504ef68b12536ef6245f83c3602d0b8b82)
  * L1Trigger/VertexFinder/data/Quantised_model_prune_iteration_9_patternModelgraph.pb:
    
    * Added: [d6364e8](https://github.com/cms-sw/cmssw/commit/d6364e86d7e655457796816c1259fa465d17b533)
    * Deleted: [4231a75](https://github.com/cms-sw/cmssw/commit/4231a7504ef68b12536ef6245f83c3602d0b8b82)

* There are other open Pull requests which might conflict with changes you have proposed:
  
  * File  L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py  modified in PR(s): [Triplet emulator 14 0 0 pre3 #43998](https://github.com/cms-sw/cmssw/pull/43998)

Please squash the commits, so that files are not added and removed.

E2E NNVtx code for P2 L1T Primary Vertex Reconstruction Adding the network graphs Updating based on L1T OffSW review in PR#1191 Updating for the FileInPath

cmsbuild · 2024-03-06T14:31:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44315/39360

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py modified in PR(s): Triplet emulator 14 0 0 pre3 #43998, Update of the Phase-2 GMT Emulator #44319

cmsbuild · 2024-03-06T14:31:27Z

Pull request #44315 was updated. @aloeliger, @epalencia, @cmsbuild, @subirsarkar, @srimanob can you please check and sign again.

epalencia · 2024-03-06T14:57:18Z

Please test

cmsbuild · 2024-03-06T19:07:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37941/summary.html
COMMIT: 5c0d13a
CMSSW: CMSSW_14_1_X_2024-03-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44315/37941/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37941/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfc93/37941/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 168 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3293028
DQMHistoTests: Total failures: 1366
DQMHistoTests: Total nulls: 16
DQMHistoTests: Total successes: 3291626
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -7.024 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -0.439 KiB Physics/NanoAODDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2024-03-07T14:40:01Z

+l1

Reviewed by L1 in E2E NNVtx: A L1T Phase 2 Vertexing algorithm using End to End NN cms-l1t-offline/cmssw#1191 & E2E NNVtx: A L1T Phase 2 Vertexing algorithm using End to End NN (CMSSW14) cms-l1t-offline/cmssw#1216

subirsarkar · 2024-03-07T17:12:34Z

+Upgrade

cmsbuild · 2024-03-07T17:12:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-07T17:52:37Z

+1

First pass adding NNvtx and NNassociation

41a30af

cmsbuild added this to the CMSSW_14_1_X milestone Mar 5, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Mar 5, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 5, 2024

cmsbuild added the requires-external label Mar 5, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 5, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 5, 2024

Squashing commits together to avoid adding and deleting model data files

5c0d13a

E2E NNVtx code for P2 L1T Primary Vertex Reconstruction Adding the network graphs Updating based on L1T OffSW review in PR#1191 Updating for the FileInPath

BenjaminRS force-pushed the L1TP2_PVMLDev_v6 branch from 7223df4 to 5c0d13a Compare March 6, 2024 14:23

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 6, 2024

cmsbuild removed the code-checks-pending label Mar 6, 2024

cmsbuild added the code-checks-approved label Mar 6, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 6, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 6, 2024

cmsbuild added l1-approved and removed l1-pending labels Mar 7, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 7, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 7, 2024

cmsbuild merged commit eff4752 into cms-sw:master Mar 7, 2024
12 checks passed

This was referenced Mar 8, 2024

Update gbl to V03-01-01 and millepede to V04-16-00 cms-sw/cmsdist#9053

Merged

Refactor scatterer addition in aGblPoint to explicitly specify type for scatPrecision.inverse() #44340

Merged

Update to CUDA 12.4.0 cms-sw/cmsdist#9046

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315

E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315

BenjaminRS commented Mar 5, 2024

cmsbuild commented Mar 5, 2024 •

edited

Loading

cmsbuild commented Mar 5, 2024

cmsbuild commented Mar 5, 2024

epalencia commented Mar 5, 2024

epalencia commented Mar 5, 2024

cmsbuild commented Mar 5, 2024

fwyzard commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

epalencia commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

aloeliger commented Mar 7, 2024

subirsarkar commented Mar 7, 2024

cmsbuild commented Mar 7, 2024

antoniovilela commented Mar 7, 2024

E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315

E2E NNVtx: A Phase 2 L1T Vertexing algorithm using End to End NN #44315

Conversation

BenjaminRS commented Mar 5, 2024

PR description:

PR validation:

cmsbuild commented Mar 5, 2024 • edited Loading

cmsbuild commented Mar 5, 2024

cmsbuild commented Mar 5, 2024

epalencia commented Mar 5, 2024

epalencia commented Mar 5, 2024

cmsbuild commented Mar 5, 2024

Comparison Summary

fwyzard commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

epalencia commented Mar 6, 2024

cmsbuild commented Mar 6, 2024

Comparison Summary

aloeliger commented Mar 7, 2024

subirsarkar commented Mar 7, 2024

cmsbuild commented Mar 7, 2024

antoniovilela commented Mar 7, 2024

cmsbuild commented Mar 5, 2024 •

edited

Loading